Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew release as the final step of the release #74

Closed
emmyoop opened this issue Mar 10, 2023 · 1 comment
Closed

Add Homebrew release as the final step of the release #74

emmyoop opened this issue Mar 10, 2023 · 1 comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Mar 10, 2023

Homebrew releases should happen after we successfully release to GitHub and PyPI. This will require a central workflow to actually release the formulae and then a change in each repo we release (dbt-core, dbt-snowflake, etc) to the release.yml file.

Release to homebrew if:

  1. This is not a test run
  2. The release was otherwise successful
  3. We are not releasing dbt-spark

Unknowns

  1. Should we release every pre-release? Only some?
  2. How can we determine if this should be marked as latest? Fix latest tag in GitHub releases #73 might help inform this.
  3. Is there a way to test this?

Current release workflow live in homebrew-dbt: formula.yml

This is to prevent this from happening again.

@emmyoop
Copy link
Member Author

emmyoop commented Mar 10, 2023

This makes this most sense to be it's own workflow as opposued to adding to the current workflows. But I'm not really sure it should live in here or just be a step in the existing release flows in each repo (ex: dbt-core release.yml) where we callout to formula.yml.

@emmyoop emmyoop added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed oss_tooling labels Aug 3, 2023
@emmyoop emmyoop closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

1 participant