Fix macos14 tests on 1.5 #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Judging from this manual CI run, we need to use brackets around these.... https://github.com/dbt-labs/dbt-redshift/actions/runs/11927014503 Are PR checks still using the already-checked-in version? If so, this would explain for why they failed here but passed in the linked CI run |
mikealfare
reviewed
Nov 20, 2024
| const defaultPythonVersion = "3.9"; | ||
| const supportedPythonVersions = ["3.9", "3.10", "3.11"]; | ||
| const defaultPythonVersion = "3.10"; | ||
| const supportedPythonVersions = ["3.9", "3.10", "3.11", "3.12"]; |
There was a problem hiding this comment.
We don't support 3.12 on this version.
VersusFacit
force-pushed
the
fix_macos14_tests_on_1.5
branch
from
2dae269 to
b2aa24a
Compare
mikealfare
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
1.4 tests will fail on macos until we fix this.
Solution
Go to a version with a psycopg2 binary.
Checklist