[Bug] Fix scenario where dbt attempts to add existing columns to relations when using the SDK for column metadata #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
commented
Sep 27, 2024
| from dbt.tests.util import get_model_file, relation_from_name, set_model_file | ||
|
|
||
|
|
||
| def update_model(project, name: str, model: str) -> str: |
There was a problem hiding this comment.
This was copy/pasted from other adapters. We should move it to dbt-tests-adapter eventually, but that would complicate this PR. It should be done as a separate exercise.
…existing-columns' into pg-catalog-migration/fix-adding-existing-columns
mikealfare
commented
Oct 9, 2024
mikealfare
commented
Oct 9, 2024
| @@ -28,6 +24,10 @@ def test_columns_in_relation(self, project, expected_columns): | |||
| ) | |||
| with project.adapter.connection_named("_test"): | |||
| actual_columns = project.adapter.get_columns_in_relation(my_relation) | |||
| expected_columns = [ | |||
There was a problem hiding this comment.
Since we are aliasing dtypes back to the original names, we don't need to specify the expected column dtypes based on whether the flag is enabled.
|
We elected to remove this functionality until we can resolve the discrepancy between our custom query and |
mikealfare
deleted the
pg-catalog-migration/fix-adding-existing-columns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #914
Problem
When using the
redshift_connectorSDK to collect metadata about a relation,dbt-redshiftattempts to add a column to a model which already exists on the model. This does not occur when using the legacy metadata query.Solution
Still investigating, but it appears this could be related to case sensitivity and/or quoting. Changing a column from unquoted to quoted on an incremental model results in the error that the user reported. However, this error also occurs when using the legacy metadata query.
Checklist