Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-927] [Feature] Update boto3 to 1.29.* version #624

Closed
3 tasks done
samjeckert opened this issue Oct 4, 2023 · 6 comments · Fixed by #674, #678, #677 or #704
Closed
3 tasks done

[ADAP-927] [Feature] Update boto3 to 1.29.* version #624

samjeckert opened this issue Oct 4, 2023 · 6 comments · Fixed by #674, #678, #677 or #704
Assignees
@VersusFacit
Labels
enhancement New feature or request good_first_issue Good for newcomers help_wanted Extra attention is needed support

Comments

@samjeckert
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-redshift functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Boto3 is pinned to the 1.26.* series, which is three major versions behind. This prevents use of updated awscli, boto3, botocore in conjunction with dbt-redshift

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@samjeckert samjeckert added enhancement New feature or request triage labels Oct 4, 2023
@github-actions github-actions bot changed the title [Feature] Update boto3 to 1.29.* version [ADAP-927] [Feature] Update boto3 to 1.29.* version Oct 4, 2023
@dataders
Copy link
Contributor

No objection to this! Would you like to open the PR? Certainly a low-hanging effort. If you're not interested, @soksamnanglim can pick it up.

@dataders dataders added good_first_issue Good for newcomers help_wanted Extra attention is needed awaiting_response and removed triage labels Oct 16, 2023
@soksamnanglim
Copy link
Contributor

Hi, thanks for opening this issue!
After a quick comb-through the repo, I don't see boto3 being directly used in dbt-redshift. See here. Is it even being used?

Could we just remove the pin? Or would you prefer updating this? @dataders

@hexDoor hexDoor mentioned this issue Nov 29, 2023
Merged
4 tasks
VersusFacit added a commit that referenced this issue Nov 30, 2023
@hexDoor @VersusFacit
Fix #624 by removing unnecessary boto3 version peg (#674)
0562935 
* remove boto3 peg

* add changelog entry

* remove boto3 refs in tests + mark skip flakey test

---------

Co-authored-by: Mila Page <[email protected]>
@mikealfare
Copy link
Contributor

mikealfare commented Nov 30, 2023 •
edited
Loading

@dbt-labs/core-adapters We'll need to backport this to the appropriate minors (at least 1.6 as this affects 1.6.x) and release before moving this to Done.

@mikealfare mikealfare added support and removed triage labels Nov 30, 2023
@mikealfare mikealfare reopened this Nov 30, 2023
VersusFacit added a commit that referenced this issue Nov 30, 2023
@hexDoor @VersusFacit
Fix #624 by removing unnecessary boto3 version peg (#674)
25a1276 
* remove boto3 peg

* add changelog entry

* remove boto3 refs in tests + mark skip flakey test

---------

Co-authored-by: Mila Page <[email protected]>
VersusFacit added a commit that referenced this issue Nov 30, 2023
@hexDoor @VersusFacit
Fix #624 by removing unnecessary boto3 version peg (#674)
a49335c 
* remove boto3 peg

* add changelog entry

* remove boto3 refs in tests + mark skip flakey test

---------

Co-authored-by: Mila Page <[email protected]>
@VersusFacit
Copy link
Contributor

VersusFacit commented Nov 30, 2023 •
edited
Loading

Backports to be done shortly done

VersusFacit added a commit that referenced this issue Nov 30, 2023
@VersusFacit @hexDoor
Fix #624 by removing unnecessary boto3 version peg (#674) (#677)
6a57662 
* remove boto3 peg

* add changelog entry

* remove boto3 refs in tests + mark skip flakey test

---------

Co-authored-by: Kyu-Sang Kim <[email protected]>
VersusFacit added a commit that referenced this issue Nov 30, 2023
@VersusFacit @hexDoor
Fix #624 by removing unnecessary boto3 version peg (#674) (#678)
3168af0 
* remove boto3 peg

* add changelog entry

* remove boto3 refs in tests + mark skip flakey test

---------

Co-authored-by: Kyu-Sang Kim <[email protected]>
This was linked to pull requests Dec 1, 2023
Backport #674 to 1.7.latest #678
Merged
Backport #674 to 1.6.latest #677
Merged
@mikealfare
Copy link
Contributor

I linked the two backports and moved this into Merged. We can move it to Done after verifying the release next Thursday.

@mikealfare
Copy link
Contributor

I've verified that dbt-redshift==1.7.1 on PyPI now installs with boto3==1.33.10. This was also applied to dbt-redshift==1.6.5. Closing as complete.

@colin-rogers-dbt colin-rogers-dbt mentioned this issue Jan 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VersusFacit VersusFacit

Labels
enhancement New feature or request good_first_issue Good for newcomers help_wanted Extra attention is needed support
Projects
None yet
Milestone
No milestone
5 participants
@dataders @mikealfare @samjeckert @VersusFacit @soksamnanglim