Full redshift connector parameter support #559
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #332
docs dbt-labs/docs.getdbt.com/#
alternative for #323
Problem
Currently not all connection methods, which the
redshift_connector
supports are currently possible withdbt-redshift
.Also the
connections.py
does not fully reflect the move toredshift_connector
yet. In the past the connection methods were handled bydbt-redshift
itself, by parsing different credentials sets based on the connectionsmethod
. Withredshift_connector
this should now be done byredshift_connector
.Solution
I have added all connection parameters from
redshift_connector
and removed the ConnectionFactory, as all connection methods are handled byredshift_connector
now.Many unit tests are now obsolete, as testing the different connection methods are now out of scope for
dbt-redshift
, but part ofredshift_connector
.All the changes should be backwards compatible.
Checklist
Lots new adapter credentials options