Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-701] [Regression] query commenting is not possible from 1.5.0 onwards #536

Closed
2 tasks done
dataders opened this issue Jul 13, 2023 · 0 comments · Fixed by #537
Closed
2 tasks done

[ADAP-701] [Regression] query commenting is not possible from 1.5.0 onwards #536

dataders opened this issue Jul 13, 2023 · 0 comments · Fixed by #537
Labels
type:bug Something isn't working type:regression

Comments

@dataders
Copy link
Contributor

dataders commented Jul 13, 2023 •
edited by dbeatty10
Loading

Is this a regression in a recent version of dbt-redshift?

  • I believe this is a regression in dbt-redshift functionality
  • I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior

this gist shows that sql = self._add_query_comment(sql) was removed as part of #251. and never added back. this omission was not picked up due to faulty tests that were surfaced in dbt-labs/dbt-core#7928.
@github-actions github-actions bot changed the title [Regression] query commenting is not possible from 1.5.0 onwards [ADAP-701] [Regression] query commenting is not possible from 1.5.0 onwards Jul 13, 2023
@dataders dataders mentioned this issue Jul 13, 2023
Merged
4 tasks
@dbeatty10 dbeatty10 mentioned this issue Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working type:regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add query commenting back dbt-labs/dbt-redshift
2 participants
@dataders @dbeatty10