Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize some unittest #9988

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Reorganize some unittest #9988

merged 1 commit into from
Apr 19, 2024

Conversation

ChenyuLInx
Copy link
Contributor

#9961

This PR

  • deleted tests that are moved to dbt-adapters
    • test_base_column.py
    • test_cache.py
  • moved and reorganized the following tests
    • test_cli_flags.py
    • test_cli.py
    • test_config.py
    • test_constraint_parsing.py

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner April 19, 2024 17:35
@cla-bot cla-bot bot added the cla:yes label Apr 19, 2024
@ChenyuLInx ChenyuLInx added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Apr 19, 2024
@ChenyuLInx ChenyuLInx requested a review from QMalcolm April 19, 2024 17:35
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (4811ada) to head (aa0be57).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9988      +/-   ##
==========================================
- Coverage   88.18%   83.56%   -4.62%     
==========================================
  Files         181      181              
  Lines       22593    22593              
==========================================
- Hits        19923    18880    -1043     
- Misses       2670     3713    +1043
Flag Coverage Δ
integration 83.56% <ø> (-2.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenyuLInx ChenyuLInx merged commit 8736508 into main Apr 19, 2024
65 of 66 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/unittest-reorg branch April 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

Assignees
No one assigned
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChenyuLInx @QMalcolm