clear DBT_DEBUG after test_env_vars_secrets #9978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
approved these changes
Apr 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9978 +/- ##
==========================================
- Coverage 88.12% 88.10% -0.02%
==========================================
Files 181 181
Lines 22581 22581
==========================================
- Hits 19900 19896 -4
- Misses 2681 2685 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #N/A
Problem
Flaky
test_check_for_spaces_in_model_names.pyfails when whole integration test suite is run, blocking releasing here: https://github.com/dbt-labs/dbt-core/actions/runs/8739875391Solution
pytest tests/functional/context_methods/test_env_vars.py tests/functional/manifest_validations/test_check_for_spaces_in_model_names.pyare failing reliably when run together. test_env_vars sets theDBT_DEBUGenv var, which causescheck_for_spaces_in_model_namesto change its behaviour.Fix
test_env_varsto properly cleanup its state after completion.Checklist
pytest tests/functional/context_methods/test_env_vars.py tests/functional/manifest_validations/test_check_for_spaces_in_model_names.pypasses reliably now :)