From c2d4afac22036182a549f0fedcd32917c46cabf8 Mon Sep 17 00:00:00 2001 From: Kshitij Aranke Date: Mon, 29 Jan 2024 15:37:05 +0000 Subject: [PATCH 1/5] [Backport 1.2.latest] Pin `pytest` in `dev-requirements.txt` --- dev-requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-requirements.txt b/dev-requirements.txt index 251b9a0ed43..eeb8a4da5f6 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -8,9 +8,9 @@ ipdb mypy==0.961 pip-tools pre-commit -pytest +pytest~=7.4 pytest-cov -pytest-csv +pytest-csv~=3.0 pytest-dotenv pytest-logbook pytest-mock From dab36571b275af73a2a8ca4999e859f0dacf228f Mon Sep 17 00:00:00 2001 From: Kshitij Aranke Date: Wed, 31 Jan 2024 14:40:29 +0000 Subject: [PATCH 2/5] Add Rust backtrace --- .github/workflows/structured-logging-schema-check.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/structured-logging-schema-check.yml b/.github/workflows/structured-logging-schema-check.yml index bd170082111..f8c39bec4df 100644 --- a/.github/workflows/structured-logging-schema-check.yml +++ b/.github/workflows/structured-logging-schema-check.yml @@ -34,6 +34,8 @@ jobs: DBT_TEST_USER_1: dbt_test_user_1 DBT_TEST_USER_2: dbt_test_user_2 DBT_TEST_USER_3: dbt_test_user_3 + # Rust debugging + RUST_BACKTRACE: 1 steps: - name: checkout dev From e10dd7c60b139700e3f29c26c048bab95abc23fb Mon Sep 17 00:00:00 2001 From: Kshitij Aranke Date: Wed, 31 Jan 2024 15:08:16 +0000 Subject: [PATCH 3/5] Rust full backtrace --- .github/workflows/structured-logging-schema-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/structured-logging-schema-check.yml b/.github/workflows/structured-logging-schema-check.yml index f8c39bec4df..ee2ca6f7ea3 100644 --- a/.github/workflows/structured-logging-schema-check.yml +++ b/.github/workflows/structured-logging-schema-check.yml @@ -35,7 +35,7 @@ jobs: DBT_TEST_USER_2: dbt_test_user_2 DBT_TEST_USER_3: dbt_test_user_3 # Rust debugging - RUST_BACKTRACE: 1 + RUST_BACKTRACE: full steps: - name: checkout dev From c2ed90f73911086ad9776004f806864594cad94d Mon Sep 17 00:00:00 2001 From: Kshitij Aranke Date: Wed, 31 Jan 2024 15:33:34 +0000 Subject: [PATCH 4/5] Upload dbt.log as an artifact --- .github/workflows/structured-logging-schema-check.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/structured-logging-schema-check.yml b/.github/workflows/structured-logging-schema-check.yml index ee2ca6f7ea3..4a79268188a 100644 --- a/.github/workflows/structured-logging-schema-check.yml +++ b/.github/workflows/structured-logging-schema-check.yml @@ -72,6 +72,12 @@ jobs: - name: Run integration tests run: tox -e integration -- -nauto + - name: Archive code coverage results + uses: actions/upload-artifact@v4 + with: + name: dbt-log + path: dbt-core/dbt-core/logs/dbt.log + # apply our schema tests to every log event from the previous step # skips any output that isn't valid json - uses: actions-rs/cargo@v1 From 7e573d12eda24834c727de5350a3743140304645 Mon Sep 17 00:00:00 2001 From: Kshitij Aranke Date: Wed, 31 Jan 2024 15:45:03 +0000 Subject: [PATCH 5/5] Fix upload path --- .github/workflows/structured-logging-schema-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/structured-logging-schema-check.yml b/.github/workflows/structured-logging-schema-check.yml index 4a79268188a..b78a2907c57 100644 --- a/.github/workflows/structured-logging-schema-check.yml +++ b/.github/workflows/structured-logging-schema-check.yml @@ -76,7 +76,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dbt-log - path: dbt-core/dbt-core/logs/dbt.log + path: dbt-core/logs/dbt.log # apply our schema tests to every log event from the previous step # skips any output that isn't valid json