Add meta to SemanticModels #8754
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8754 +/- ##
==========================================
+ Coverage 86.50% 86.53% +0.02%
==========================================
Files 176 176
Lines 25820 25825 +5
==========================================
+ Hits 22336 22348 +12
+ Misses 3484 3477 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
emmyoop
requested review from
chrismorrisette-dbt and
QMalcolm
and removed request for
a team
| # If we have meta in the config, copy to node level, for backwards | ||
| # compatibility with earlier node-only config. | ||
| if "meta" in config and config["meta"]: | ||
| parsed.meta = config["meta"] |
There was a problem hiding this comment.
Why do we have to support the legacy way for a new node?
There was a problem hiding this comment.
@QMalcolm specifically because of this comment in the original issue.
There was a problem hiding this comment.
I've pinged @jtcohen6 for clarity on this. I read that comment to mean we've left the top level meta attribute on existing nodes to support backwards compatibility, but I now see that it can also be read to mean we need to add it to all new nodes for backwards compatibility.
|
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4180 |
resolves #8511
docs
Problem
No meta attribute on SemanticModels
Solution
Add meta under configs
Checklist