Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test GraphQueue class #9872

Closed
1 task done
Tracked by #9649
QMalcolm opened this issue Apr 8, 2024 · 2 comments
Closed
1 task done
Tracked by #9649

Unit test GraphQueue class #9872

QMalcolm opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
Refinement Maintainer input needed

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Apr 8, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of our Robust Testing Initiative we want to create generalized fixtures for our unit tests to make writing unit tests easier. To that end we want to add or update unit some unit tests to utilize the new fixture. Currently the GraphQueue class is not unit tested at all. We could unit test by reusing the DiGraph fixture created in #9871.

Acceptance criteria

Suggested Tests

The work is the tests

Impact to Other Teams

None

Will backports be required?

Narp

Context

@QMalcolm QMalcolm added the Refinement Maintainer input needed label Apr 8, 2024
@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Apr 8, 2024

This should include testing the public interfaces.

@ChenyuLInx
Copy link
Contributor

The work @MichelleArk(Thanks!) did in #10129 accomplished this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refinement Maintainer input needed
Projects
None yet
Development

No branches or pull requests

2 participants