Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Project fixture and unit test Project class #9870

Closed
1 task done
Tracked by #9649
QMalcolm opened this issue Apr 8, 2024 · 0 comments · Fixed by #10022
Closed
1 task done
Tracked by #9649

Create Project fixture and unit test Project class #9870

QMalcolm opened this issue Apr 8, 2024 · 0 comments · Fixed by #10022
Assignees

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Apr 8, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of our Robust Testing Initiative we want to create generalized fixtures for our unit tests to make writing unit tests easier. To that end we want to add or update unit some unit tests to utilize the new fixture. Currently the config Project class is not unit tested at all. We could unit test a majority of the the class (except for instantiation) by having a Project fixture. Additionally many other parts of the codebase (both functions and classes) take in the config Project class as a variable. Thus creating the fixture would make it easier to create unit tests for other parts of the codebase

Acceptance criteria

  • There is a generic project unit test fixture
  • There are unit tests for the config Project class

Suggested Tests

The work is the tests

Impact to Other Teams

None

Will backports be required?

Narp

Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants