Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize: Move test_d* unit tests into files/directories that mimic source code being tested #9663

Closed
1 task done
QMalcolm opened this issue Feb 26, 2024 · 1 comment
Closed
1 task done
Assignees

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Feb 26, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of our Robust Testing Initiative we want to re-organize our unit tests to mimic the source code directory and files. Doing one file is generally smaller than what we'd rank as one unit of work, so this is a grouping of multiple. Here we want take unit tests in unit test files starting with test_d* and reorganize them into appropriate files within appropriate directories. This includes: test_deprecations.py, test_deps.py, test_doc_blocks.py, and test_docs_generate.py. These files contain 36 unit tests.

Acceptance criteria

The unit tests in test_deprecations.py, test_deps.py, test_doc_blocks.py, and test_docs_generate.py have been moved to files within a directory structure under tests/unit/ that mirror the organization of the source code being tested.

Suggested Tests

The work is the tests

Impact to Other Teams

None

Will backports be required?

Narp

Context

#9649

@QMalcolm QMalcolm added Refinement Maintainer input needed and removed Refinement Maintainer input needed labels Feb 26, 2024
@QMalcolm
Copy link
Contributor Author

Duplicate of #9961

@QMalcolm QMalcolm marked this as a duplicate of #9961 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant