Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3171] [Bug] user docs autogenerated issues sometimes are duplicated #8746

Closed
2 tasks done
emmyoop opened this issue Sep 29, 2023 · 0 comments · Fixed by #8747
Closed
2 tasks done

[CT-3171] [Bug] user docs autogenerated issues sometimes are duplicated #8746

emmyoop opened this issue Sep 29, 2023 · 0 comments · Fixed by #8747
Assignees
Labels
bug Something isn't working

Comments

@emmyoop
Copy link
Member

emmyoop commented Sep 29, 2023

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

We're seeing some weirdness with the GitHub Action. See how this Core PR created two bot comments that created two docs issues: this one and this one.

Expected Behavior

Only 1 issue gets generated per PR - this can be accomplished by checking that the label added by the labeled event was user docs

Steps To Reproduce

This is really a timing issue. In the case of the above PR, a label was added right after the PR was merged causing the workflow to trigger twice and since they ran simultaneously neither saw the comment the other generated in time to know to skip creating a new issue in the docs.getdbt.com repo.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

@emmyoop emmyoop added bug Something isn't working triage labels Sep 29, 2023
@github-actions github-actions bot changed the title [Bug] user docs autogenerated issues sometimes are duplicated [CT-3171] [Bug] user docs autogenerated issues sometimes are duplicated Sep 29, 2023
@emmyoop emmyoop self-assigned this Sep 29, 2023
@dbeatty10 dbeatty10 removed the triage label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants