Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3106] Refactor ManifestLoader.load method #8618

Open
MichelleArk opened this issue Sep 11, 2023 · 2 comments · May be fixed by #9121
Open

[CT-3106] Refactor ManifestLoader.load method #8618

MichelleArk opened this issue Sep 11, 2023 · 2 comments · May be fixed by #9121
Assignees
@aranke
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

This method is quite long and difficult to understand its overall logic - let's start refactoring it by extracting methods and using them in ManifestLoader.load
@MichelleArk MichelleArk added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Sep 11, 2023
@github-actions github-actions bot changed the title Refactor ManifestLoader.load method [CT-3106] Refactor ManifestLoader.load method Sep 11, 2023
@martynydbt
Copy link

what should we do with this ticket if it isn't finished this sprint? reassign? since you're out @aranke

@aranke
Copy link
Member

aranke commented Oct 10, 2023

That works, or I can pick it back up when I have capacity on the board again.

@aranke aranke linked a pull request Nov 21, 2023 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aranke aranke

Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #8618: Refactor ManifestLoader.load dbt-labs/dbt-core
3 participants
@MichelleArk @aranke @martynydbt