Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2843] Add Partial Parsing tests for Semantic Models #8140

Closed
Tracked by #8125
QMalcolm opened this issue Jul 18, 2023 · 2 comments
Closed
Tracked by #8125

[CT-2843] Add Partial Parsing tests for Semantic Models #8140

QMalcolm opened this issue Jul 18, 2023 · 2 comments
Assignees
@QMalcolm
Labels
semantic Issues related to the semantic layer tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@QMalcolm
Copy link
Contributor

Context

SemanticModels are currently supported by partial parsing. However, we have no tests for this functionality. We do have a file for those tests, test_pp_semantic_models.py, but it's currently empty.

Acceptance Criteria

  • Tests exists in test_pp_semantic_models.py that reasonably test the partial parsing functionality of SemanticModels
@QMalcolm QMalcolm added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language semantic Issues related to the semantic layer labels Jul 18, 2023
@QMalcolm QMalcolm added this to the v1.7 milestone Jul 18, 2023
@QMalcolm QMalcolm mentioned this issue Jul 18, 2023
Closed
@github-actions github-actions bot changed the title Add Partial Parsing tests for Semantic Models [CT-2843] Add Partial Parsing tests for Semantic Models Jul 18, 2023
@QMalcolm QMalcolm mentioned this issue Jul 18, 2023
Closed
@jtcohen6 jtcohen6 removed this from the v1.7 milestone Jul 19, 2023
@QMalcolm
Copy link
Contributor Author

QMalcolm commented Aug 4, 2023

I plan on finishing this off once I get back on 08/14/2023

@QMalcolm
Copy link
Contributor Author

So when I created this I missed that there were partial parsing tests in tests/functional/semantic_models/tests_semantic_model_parsing.py. In #8310 we added some additional partial parsing tests. Semantic models seem like they're in a pretty good state now 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QMalcolm QMalcolm

Labels
semantic Issues related to the semantic layer tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QMalcolm @jtcohen6