You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #7769 we added SemanticModel nodes in core. We started this work while pointed at DSI 0.1.0dev2 but midway updated to depend on DSI 0.1.0dev3. The main problem is that there are some protocol changes from DSI dev2 to DSI dev3, specifically SemanticModel.dimensions[x].is_primary has moved to SemanticModel.defaults.agg_time_dimension. Due to our serialization process, the semantic manifest artifact contains neither is_primary or agg_time_dimension 🙃 This issue was able to slip through because we don't check currently in core that our node implementations satisfy the protocol. Thus in solving this issue we should not only correct the nodes, but also add tests to verify that our nodes satisfy the DSI protocols.
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
[BUG] Update SemanticModel definitions to match DSI 0.1.0dev3 protocols
[CT-2677] [BUG] Update SemanticModel definitions to match DSI 0.1.0dev3 protocols
Jun 9, 2023
I'm not sure this is so much a duplicate as it is just simply related. #7827 brings up that we need a way to ensure the nodes satisfy the protocol. This issue is specifically about fixing a bug which is that one of our nodes doesn't currently satisfy the protocol.
In #7769 we added SemanticModel nodes in core. We started this work while pointed at DSI 0.1.0dev2 but midway updated to depend on DSI 0.1.0dev3. The main problem is that there are some protocol changes from DSI dev2 to DSI dev3, specifically
SemanticModel.dimensions[x].is_primary
has moved toSemanticModel.defaults.agg_time_dimension
. Due to our serialization process, the semantic manifest artifact contains neitheris_primary
oragg_time_dimension
🙃 This issue was able to slip through because we don't check currently in core that our node implementations satisfy the protocol. Thus in solving this issue we should not only correct the nodes, but also add tests to verify that our nodes satisfy the DSI protocols.The text was updated successfully, but these errors were encountered: