Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2587] [Feature] Support Query Tagging in Base Materializations #7648

Open
3 tasks done
trouze opened this issue May 17, 2023 · 2 comments · May be fixed by #7770
Open
3 tasks done

[CT-2587] [Feature] Support Query Tagging in Base Materializations #7648

trouze opened this issue May 17, 2023 · 2 comments · May be fixed by #7770
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors Team:Adapters Issues designated for the adapter area of the code

Comments

@trouze
Copy link
Contributor

trouze commented May 17, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Would like to continue a discussion happening over on dbt-redshift relating to the addition of query tagging on that adapter. As other adapters are also adding this feature, I think it makes sense to plug this into dbt-core materializations and have each adapter implement macros specific to how their database implements the query tagging functionality.

This is related to discussions happening around adding this functionality to dbt-bigquery and dbt-redshift. The motivation for this is to bring what is becoming a more common feature across databases into core, limiting the repetition of this logic across adapters as discussed here.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

Yes

Anything else?

No response

@trouze trouze added enhancement New feature or request triage labels May 17, 2023
@trouze trouze changed the title [Feature] Support Query Tagging in Base Materializations [CT-2587] [Feature] Support Query Tagging in Base Materializations Jun 2, 2023
@trouze trouze linked a pull request Jun 2, 2023 that will close this issue
6 tasks
@trouze
Copy link
Contributor Author

trouze commented Jun 2, 2023

I've added a basic vision for what this might look like. I'm not entirely sure how to handle when the query tagging concept isn't implemented within a specific adapter, especially since Postgres does not support this so we basically want to pass over and log the fact that query tagging isn't supported (or hasn't been implemented yet) for your current adapter.

@jtcohen6 jtcohen6 added the Team:Adapters Issues designated for the adapter area of the code label Jun 25, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 25, 2023

@trouze Thanks for opening up the issue, and the PR!

I'm glad to see some logic from dbt-snowflake making its way upstream into dbt-core, now that Redshift & BigQuery could both support something similar-enough. I haven't gone deep on every linked issue/PR, but I'm broadly supportive of keeping the interface consistent across the board, and it seems like we have a real chance to do that here.

@jtcohen6 jtcohen6 added help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors and removed triage labels Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help_wanted Trickier changes, with a clear starting point, good for previous/experienced contributors Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants