-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1411] [Feature] Support Python 3.11 #6147
Comments
https://docs.python.org/3.11/whatsnew/3.11.html#faster-cpython
It took a teensy bit of finagling (48e6f96), but I was able to experiment running Completely anecdotal evidence: Running on my M1 locally, a full parse is ~3x faster (just over 9 seconds, instead of just under 27 seconds) for our internal analytics project (almost 2k files, 700+ models) compared with 3.9.13. I'm going to remove the |
We should open up issues for each adapter repo as well |
✅ done! |
@leahwicz @nathaniel-may @jtcohen6 I'm going to assign this one to the adapter team unless there's a huge outcry. We have to do the 4 adapters + Postgres anyway so... |
@Fleid if Adapters wants to do this, that is fine with me. #6326 has already been put up as a draft PR and but still needs works obviously. I created a Slack thread in #dev-core to consolidate knowledge on who has looked at what so far with Python 3.11 and then we can have an Adapters person pick it up from there |
Folks the Dockerfile is currently pinned to 3.10 due to a bug - any plans to upgrade to 3.11? |
Hey @jelstongreen ! Just replied to you here: #9491 (comment) |
Is this your first time submitting a feature request?
Describe the feature
Support Python 3.11.x in dbt Core and adapters:
Describe alternatives you've considered
No response
Who will this benefit?
Folks using the most recent release of Python
Are you interested in contributing this feature?
Will mark as a "good first issue" and let someone else take a shot at this
Anything else?
Last time
It looks like this work was split across multiple PRs last time, but it would be nice to have a single PR this time:
How to implement
Add 3.11 (and 3.10 when it is missing) to these locations:
dbt-core/core/setup.py
Lines 82 to 84 in 1916784
dbt-core/tests/adapter/setup.py
Lines 53 to 54 in 1916784
dbt-core/plugins/postgres/setup.py
Lines 84 to 86 in 1916784
dbt-core/tox.ini
Line 5 in 1916784
dbt-core/tox.ini
Line 17 in 1916784
dbt-core/.github/workflows/main.yml
Line 74 in 1916784
dbt-core/.github/workflows/main.yml
Line 119 in 1916784
dbt-core/Dockerfile.test
Lines 46 to 51 in 1916784
dbt-core/CONTRIBUTING.md
Line 59 in 1916784
dbt-core/CONTRIBUTING.md
Line 163 in 1916784
The text was updated successfully, but these errors were encountered: