-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for dbt_project.yml "tests" config resulting in incorrect state:modified #11166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11166 +/- ##
==========================================
- Coverage 88.88% 88.84% -0.05%
==========================================
Files 187 187
Lines 24001 24011 +10
==========================================
- Hits 21334 21332 -2
- Misses 2667 2679 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
def test_unrendered_config(self, project): | ||
manifest = run_dbt(["parse"]) | ||
assert manifest | ||
print(f"--- nodes: {manifest.nodes.keys()}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove print
Resolves #11146
Problem
If the data_tests config in dbt_project.yml is named "tests", the unrendered_config for data tests is incorrect, resulting in incorrect state:modified results.
Solution
Rename the "tests" dictionary to "data_tests", so unrendered config is correctly generated.
Checklist