Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom SQL for get source maxLoadedAt #11163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Dec 18, 2024

Resolves #8797

This PR adds the ability to specify a custom sql to generate the maxLoadedAt time stamp on the source

video1790688049.mp4

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner December 18, 2024 00:50
@cla-bot cla-bot bot added the cla:yes label Dec 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (7df04b0) to head (40844ad).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11163      +/-   ##
==========================================
- Coverage   88.92%   85.80%   -3.12%     
==========================================
  Files         187      187              
  Lines       23974    24038      +64     
==========================================
- Hits        21318    20627     -691     
- Misses       2656     3411     +755     
Flag Coverage Δ
integration 81.71% <94.11%> (-4.59%) ⬇️
unit 62.06% <79.41%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.06% <79.41%> (+0.08%) ⬆️
Integration Tests 81.71% <94.11%> (-4.59%) ⬇️

@ChenyuLInx ChenyuLInx added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Dec 18, 2024
@@ -1,4 +1,4 @@
git+https://github.com/dbt-labs/dbt-adapters.git@main
git+https://github.com/dbt-labs/dbt-adapters.git@cl/custom_freshness_sql
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert before merge

@ChenyuLInx ChenyuLInx force-pushed the cl/custom_freshness_sql branch from e3f0628 to d9785b4 Compare December 18, 2024 01:15
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner December 18, 2024 01:15
@ChenyuLInx ChenyuLInx requested review from jzhu13 and removed request for a team December 18, 2024 01:15
@ChenyuLInx ChenyuLInx force-pushed the cl/custom_freshness_sql branch from d9785b4 to 8780b8c Compare December 18, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3194] [Feature] add another way to calculate source freshness - via a SQL query
2 participants