[Bug] Disabled generic tests appear in manifest.nodes

[emmyoop]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When you have a generic test for a model, it remains in the manifest when disabled. Other node types are only in the disabled dictionary.

Expected Behavior

• The generic test is not in in manifest.nodes
• The generic test is in the disabled dict

Steps To Reproduce

my_model.sql

select 1 as id, 'orange' as color, false as is_primary_color

schema.yml

models:
  - name: column_removed_model
    columns:
      - name: id
        tests:
          - unique

1. dbt compile and see the model and the test in manifest.nodes, disabled dictionary is empty
2. delete my_model.sql
3. dbt compile and see the test in manifest.nodes but not disabled dictionary
   or
4. dbt compile and see the model and the test in manifest.nodes, disabled dictionary is empty
5. add the enabled: false config my_model
6. dbt compile and see the test in manifest.nodes but not disabled dictionary and the model in the disabled dict but not in manifest.nodes

Relevant log output

none

Environment

- dbt: 1.9a1

Which database adapter are you using with dbt?

No response

Additional Context

TODO: Does this also apply to singular tests?

This may require some tests that verify the number of nodes in the results equals a specific number. This is an unknown that may add some time to the fix.

More context for how it works now:
In compilation.py we specifically check for disabled tests in the "nodes" dictionary. However, when we do "cleanup_disabled" anything that's disabled ought to be moved to the disabled dictionary.

[gshank]

Tests for a disabled model aren't explicitly marked as disabled are they? We move everything in the "nodes" dictionary that's marked disabled into the "disabled" dictionary as a post-parsing step.

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

[github-actions]

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.