Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] A new manifest version should be published for dbt 1.9 #10188

Closed
2 tasks done
mars-lan opened this issue May 20, 2024 · 2 comments
Closed
2 tasks done

[Bug] A new manifest version should be published for dbt 1.9 #10188

mars-lan opened this issue May 20, 2024 · 2 comments
Labels
bug Something isn't working wontfix Not a bug or out of scope for dbt-core

Comments

@mars-lan
Copy link

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Based on https://docs.getdbt.com/reference/artifacts/manifest-json, v12 is reserved for dbt 1.8. However, it seems that dbt 1.9 has started publishing an incompatible v12 manifest JSON schema (https://schemas.getdbt.com/dbt/manifest/v12.json):

{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "type": "object",
  "title": "WritableManifest",
  "properties": {
    "metadata": {
      "type": "object",
      "title": "ManifestMetadata",
      "description": "Metadata about the manifest",
      "properties": {
        "dbt_schema_version": {
          "type": "string"
        },
        "dbt_version": {
          "type": "string",
          "default": "1.9.0a1"
        },
}

Expected Behavior

dbt 1.9 should publish to a new v13 manifest JSON schema.

Steps To Reproduce

Download and inspect https://schemas.getdbt.com/dbt/manifest/v12.json

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

@mars-lan mars-lan added bug Something isn't working triage labels May 20, 2024
@dbeatty10 dbeatty10 self-assigned this May 20, 2024
@dbeatty10
Copy link
Contributor

Thanks for reaching out @mars-lan !

Looks like this was changed from 1.8.0b3 to 1.9.0a1 in dbt-labs/schemas.getdbt.com#39.

Would it solve the problem you are reporting if 1.9.0a1 was reverted back to 1.8.0b3?

@dbeatty10 dbeatty10 removed their assignment May 20, 2024
@mars-lan
Copy link
Author

Actually never mind. The issue was unrelated to the version. Closing this now.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@dbeatty10 dbeatty10 added wontfix Not a bug or out of scope for dbt-core and removed triage labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix Not a bug or out of scope for dbt-core
Projects
None yet
Development

No branches or pull requests

2 participants