Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for Project class break due to hardcoded assertion on changing version value #10056

Closed
1 task done
QMalcolm opened this issue Apr 26, 2024 · 1 comment · Fixed by #10059
Closed
1 task done
Assignees
Labels
user docs [docs.getdbt.com] Needs better documentation

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

We were seeing some breakages on dbt version change of the test test__str__. Specifically the value 'require-dbt-version': ['=1.8.0-b3'] in the assertion is causing issues. This is because in the project fixture we've created, we set the dbt-version to the actual current version, as seen here. Thus when the dbt version set here changes, the test breaks.

Acceptance criteria

dbt's version can change without breaking the test test__str__.

Suggested Tests

What we're working on here is tests

Impact to Other Teams

None

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added the user docs [docs.getdbt.com] Needs better documentation label Apr 26, 2024
@QMalcolm QMalcolm self-assigned this Apr 26, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#5399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants