Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import SECRET_ENV_PREFIX from dbt-common #10019

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Import SECRET_ENV_PREFIX from dbt-common #10019

merged 4 commits into from
Apr 24, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 23, 2024

resolves #10018

Problem

SECRET_ENV_PREFIX is defined in dbt-core and dbt-common

Solution

Import SECRET_ENV_PREFIX from dbt-common and remove the definition from dbt-core

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner April 23, 2024 19:34
@cla-bot cla-bot bot added the cla:yes label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.20%. Comparing base (29429ec) to head (c096195).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10019      +/-   ##
==========================================
+ Coverage   88.13%   88.20%   +0.06%     
==========================================
  Files         181      181              
  Lines       22638    22643       +5     
==========================================
+ Hits        19953    19973      +20     
+ Misses       2685     2670      -15     
Flag Coverage Δ
integration 85.58% <100.00%> (+0.14%) ⬆️
unit 62.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Apr 23, 2024
@emmyoop emmyoop changed the title Er/constants Import SECRET_ENV_PREFIX from dbt-common Apr 23, 2024
@emmyoop emmyoop merged commit 37b1fce into main Apr 24, 2024
62 checks passed
@emmyoop emmyoop deleted the er/constants branch April 24, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SECRET_ENV_PREFIX from dbt_common instead of dbt_core
2 participants