From 8c2ad872af07d5755ac26401f4f4c9d63577c523 Mon Sep 17 00:00:00 2001 From: McKnight-42 Date: Wed, 5 Jun 2024 10:15:00 -0500 Subject: [PATCH] feedback based on mike review --- core/dbt/parser/generic_test_builders.py | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/core/dbt/parser/generic_test_builders.py b/core/dbt/parser/generic_test_builders.py index bb54dd8e53d..6bca8300dae 100644 --- a/core/dbt/parser/generic_test_builders.py +++ b/core/dbt/parser/generic_test_builders.py @@ -131,8 +131,7 @@ def __init__( # Process config args if present if "config" in self.args: - self.config.update(self._process_config_args(self.args["config"])) - del self.args["config"] + self.config.update(self._render_values(self.args.pop("config", {}))) if self.namespace is not None: self.package_name = self.namespace @@ -165,16 +164,7 @@ def _process_legacy_args(self): raise SameKeyNestedError() if not value and "config" in self.args: value = self.args["config"].pop(key, None) - if value is not None: - config[key] = value - - return self._render_values(config) - - def _process_config_args(self, config_dict: Dict[str, Any]) -> Dict[str, Any]: - config = {} - for key, value in config_dict.items(): - if value is not None: - config[key] = value + config[key] = value return self._render_values(config)