From 4d02ef637be2eb21b1fc21e61a878bdee23ed22f Mon Sep 17 00:00:00 2001 From: Quigley Malcolm Date: Fri, 17 Nov 2023 12:24:58 -0800 Subject: [PATCH] Update comment about input_measures setting in metric parsing (#9118) In [dbt-labs/dbt-core#7984](https://github.com/dbt-labs/dbt-core/pull/7984) we began setting a metrics `type_params.input_measures` during metric processing post parsing. However in that PR we didn't clean up the comment in the parser about setting `input_measures`. This is that post fact cleanup. --- core/dbt/parser/schema_yaml_readers.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/dbt/parser/schema_yaml_readers.py b/core/dbt/parser/schema_yaml_readers.py index e9eb2b5c76c..524f0c74b17 100644 --- a/core/dbt/parser/schema_yaml_readers.py +++ b/core/dbt/parser/schema_yaml_readers.py @@ -308,9 +308,7 @@ def _get_metric_type_params(self, type_params: UnparsedMetricTypeParams) -> Metr window=self._get_time_window(type_params.window), grain_to_date=grain_to_date, metrics=self._get_metric_inputs(type_params.metrics), - # TODO This is a compiled list of measure/numerator/denominator as - # well as the `input_measures` of included metrics. We're planning - # on doing this as part of CT-2707 + # input measures are calculated via metric processing post parsing # input_measures=?, )