Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Macro Type Analysis Code to dbt-common #230

Closed
wants to merge 6 commits into from

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Dec 13, 2024

Description

This changeset moves type checking code into dbt-common, and extends it to support checks for "dbt Classes" used by adapters, like Relation and Column.

Taken by itself, this changeset doesn't do anything, but it will be used by dbt-core soon to implement type checking.

Checklist

@cla-bot cla-bot bot added the cla:yes label Dec 13, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 70.07299% with 41 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (2253401) to head (7b081b3).

Files with missing lines Patch % Lines
dbt_common/clients/jinja_macro_call.py 70.58% 40 Missing ⚠️
dbt_common/clients/jinja.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   68.89%   69.20%   +0.31%     
==========================================
  Files          52       53       +1     
  Lines        3433     3569     +136     
==========================================
+ Hits         2365     2470     +105     
- Misses       1068     1099      +31     
Flag Coverage Δ
unit 69.20% <70.07%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb marked this pull request as ready for review January 13, 2025 21:12
@peterallenwebb peterallenwebb requested a review from a team as a code owner January 13, 2025 21:12
@peterallenwebb
Copy link
Contributor Author

Pausing this set of changes as we re-asses the long term direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants