Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigquery repeated data type #236

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

Thrasi
Copy link
Contributor

@Thrasi Thrasi commented Dec 11, 2024

resolves #190

This is a:

  • bug fix with no breaking changes

Description & motivation

Separate format_column macro into default__format_column and bigquery__format_column to handle BigQuery REPEATED fields.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thrasi this looks good to me!

Once you flip this to "ready to review", then we can give final approval and then merge.

Heads-up: Tomorrow will be my last day in the office before I'll be one holiday for a few weeks. If we can get it merged tomorrow, then great. Otherwise, I can pick it back up again when I return.

@Thrasi Thrasi marked this pull request as ready for review December 13, 2024 08:14
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 13, 2024
@Thrasi
Copy link
Contributor Author

Thrasi commented Dec 13, 2024

I'm not sure how the process for updating the CHANGELOG.md but this was my attempt

@Thrasi Thrasi requested a review from dbeatty10 December 13, 2024 12:06
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @Thrasi !

@dbeatty10
Copy link
Contributor

I'm not sure how the process for updating the CHANGELOG.md but this was my attempt

Contributors don't need to manually update the CHANGELOG anymore, so I just pulled it out.

We've got a couple issues opened to update the PR template and contributing guide to remove those pieces so it isn't confusing in the future: #238 and #237

@dbeatty10 dbeatty10 merged commit 5a31c62 into dbt-labs:main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect data_type for BigQuery REPEATED fields
2 participants