-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigquery repeated data type #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thrasi this looks good to me!
Once you flip this to "ready to review", then we can give final approval and then merge.
Heads-up: Tomorrow will be my last day in the office before I'll be one holiday for a few weeks. If we can get it merged tomorrow, then great. Otherwise, I can pick it back up again when I return.
I'm not sure how the process for updating the CHANGELOG.md but this was my attempt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @Thrasi !
Contributors don't need to manually update the CHANGELOG anymore, so I just pulled it out. We've got a couple issues opened to update the PR template and contributing guide to remove those pieces so it isn't confusing in the future: #238 and #237 |
resolves #190
This is a:
Description & motivation
Separate
format_column
macro intodefault__format_column
andbigquery__format_column
to handle BigQuery REPEATED fields.Checklist