Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow base model creation to take multiple tables as arguments #233

Open
Eromtap opened this issue Dec 4, 2024 · 1 comment · May be fixed by #225
Open

Allow base model creation to take multiple tables as arguments #233

Eromtap opened this issue Dec 4, 2024 · 1 comment · May be fixed by #225
Labels
awaiting_response enhancement New feature or request

Comments

@Eromtap
Copy link

Eromtap commented Dec 4, 2024

Describe the feature

In my workflow, it is often necessary to copy multiple tables from one schema to another. The base model creation feature in DBT codegen has been awesome, but I altered it to accept more than one table arg at a time. According to the docs, it should have been able to accept multiple args before, but it wouldn't work and I didn't see any iterative logic in bash_scripts/base_model_creation.sh so I added it.

Additional context

I sent a PR ( #225 ) with the changes and was asked to provide a feature request here.

Who will this benefit?

Anyone who needs to generate copies of multiple tables. In my case, my company is moving to a different form of ingest that is requiring copying entire schemas over table by table.

Are you interested in contributing this feature?

I would love to contribute! DBT and Codegen have been game changers and I'd be honored to be a contributor!!!

@Eromtap Eromtap added enhancement New feature or request triage labels Dec 4, 2024
@dbeatty10 dbeatty10 linked a pull request Dec 5, 2024 that will close this issue
5 tasks
@dbeatty10 dbeatty10 changed the title Base model creation only takes one table as an arguement Allow base model creation to take multiple tables as arguments Dec 5, 2024
@dbeatty10
Copy link
Contributor

This sounds good to me as long as it is backwards-compatible. i.e., if a command like the following still works:

dbt run-operation codegen.create_base_models --args '{"source_name": "dbt_dbeatty", "tables": ["raw_orders", "raw_customers", "asdfasdf"]}'

Could you check to see if this would still work or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting_response enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants