-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAP-462] [Feature] Allow override of CreateBatchRequest for batch_id #671
Comments
Thanks for reaching out @nickozilla ! I'm assuming you mean And I'm guessing some variation on the following doesn't work? Full disclosure: I haven't used the
More infoThe Some relevant sections of code: dbt-bigquery/dbt/adapters/bigquery/python_submissions.py Lines 114 to 121 in 850296f
dbt-bigquery/dbt/adapters/bigquery/python_submissions.py Lines 162 to 181 in 850296f
|
Hi @dbeatty10 - yes you were right I meant
|
I see what you are saying @nickozilla 👍 The implementation of the feature you are requesting might be pretty lightweight -- would you be interested in contributing it, by any chance? No pressure tho! Implementation hintsCaveat: the following is completely untested and potentially way too optimistic 😎
|
Yeah sounds good, I'll give that a go & link back to this issue in the PR 👍 |
@dbeatty10 You were right to be optimistic, I made the change & tested locally & it was pulled in succesfully. Raised the PR for it here: #727 |
That's great news @nickozilla! 🎉 That would be a perfect screenshot to add to the pull request as well. |
@dbeatty10 do you have a rough idea of when the PR will be reviewed? Currently been open for >3weeks without any comments/reviews. |
Re-opening after the revert in #826 |
Is this your first time submitting a feature request?
Describe the feature
Currently the
dataproc_profile
supports profile configuration of a batch resource which is used in the CreateBatchRequest & leaves the batch_id undeclared forcing a random string generation. It would be better if we could customise this field ofbatch_id
optionallyDescribe alternatives you've considered
Labels mainly, but they can't be used as ui filter on the GCP console
Who will this benefit?
No response
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: