Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Circle class #3

Open
worbit opened this issue Mar 11, 2024 · 0 comments
Open

Rename Circle class #3

worbit opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@worbit
Copy link

worbit commented Mar 11, 2024

I would have two suggestions for the Circle class (https://github.com/dbt-ethz/HDMolaGH/blob/main/PrimitiveCircle.cs)

  1. Rename it to Disk (instead of Circle) because mathematically speaking, it is about the inside area, not the contour.
  2. Make it optional to triangulate it (to the centre point) or create an n-gon (don't know if Mola allows that?)
@worbit worbit added the enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@worbit