From 6b4b5bb5ff255ae3ffa375877b50faefd2c587d7 Mon Sep 17 00:00:00 2001 From: Ben Anderson Date: Tue, 19 Jan 2021 23:52:05 -0500 Subject: [PATCH] "ssl" config value should be boolean This is my first time using this library, so disregard if I'm totally off-base here, but I kept running into issues locally on the latest version of this library, with a "The server does not support SSL connections" error message, despite having `"ssl": "false"` in this config file. From what I can gather, this should be a boolean value instead of a string, as the underlying `pg` lib depends on that. I found this recent PR which led me to thta conclusion: - https://github.com/brianc/node-postgres/pull/2394/files#diff-cc6abc00177b0fba133f7ea7b2fbe025fc21e789f243cfd85f9be7e0325f0bc2R83-R89 - https://github.com/brianc/node-postgres/pull/2394/files#diff-cc6abc00177b0fba133f7ea7b2fbe025fc21e789f243cfd85f9be7e0325f0bc2R61-R63 #### Changes included: - Use boolean for "ssl" config values in documentation **Before:** using `"ssl": "false"` in config caused "The server does not support SSL connections" fatal error **After:** everything works as expected with `"ssl": false` config value --- docs/Getting Started/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Getting Started/configuration.md b/docs/Getting Started/configuration.md index 31f9417..3278842 100644 --- a/docs/Getting Started/configuration.md +++ b/docs/Getting Started/configuration.md @@ -27,7 +27,7 @@ db-migrate supports the concept of environments. For example, you might have a d "host": "localhost", "database": "mydb", "port": "20144", - "ssl": "true", + "ssl": true, "schema": "my_schema" },