Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show vacancy to moderators #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anoam
Copy link

@anoam anoam commented Oct 16, 2019

No description provided.

@@ -2,5 +2,7 @@

root to: 'dashboard#index'

get 'vacancy/:id', to: 'dashboard#show'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не очень уверен в правильности такого решения.
Просто как самая простая опция.

@@ -0,0 +1,42 @@
li.list-group-item
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опять же, вынес в партиал и использовал таким образом как самый простой вариант.


private

def for_modertion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for_moderation, typo :-)


it { expect(subject).to redirect_to '/moderation' }
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gruz0 Extra new lines are in every file, so I guess that should be considered a style guide for this project for consistency.

@davydovanton davydovanton self-requested a review July 9, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants