-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Add-on and Standalone modes #269
Comments
@davidusb-geek , I see the biggest decision being what we should do with the configuration files. If everyone should move over to the options.json or still have the two. |
Yes if this merge is done the best idea would be to just keep one type of conf file. The options.json would make more sense as it is widely the most used along with the add-on. |
I think there will be any noticeable difference for add-on. It would be more the standalone users adjusting to using |
My thoughts on the steps that would be carried out:
This is supper quick/ruff. I'll come back to this checklist after some more thought. Please feel free to comment. |
It seems like a very complete planning. |
Good question, I have been thinking about the idea of merging both repos together. (I know it's a long shot) At the moment the EMHASS-Add-on Dockerfile is pulling EMHASS via pip before it creates the image. I would need to check if the FROM tag could work in both situations. |
I don't like the idea of merging the repos. The add-on repo has the structure of a HA add-on repo, while this one has the structure of a Python package. I would like to keep that as I like the option that EMHASS can be used completely independent of HA, you just provide the correct data and it will crunch it and perform the optimization, it doesn't matter if this data comes from HA, a CSV file or a list passed by a REST command. |
Closing this as completed with #334 |
Discussion starting in: #262
EMHASS is probably in a sate where we could choose to use the local or external HA API automatically based on API key
(SUPERVISOR_TOKEN)
. Removing the need of passing it via arguments.Allowing for both Standalone and Add-on modes to merged into one.
This may be something I'll look into when I have some time. I am sure all help will be appreciated.
The text was updated successfully, but these errors were encountered: