Skip to content

Commit

Permalink
fix fast container job hangs
Browse files Browse the repository at this point in the history
Starting from Podman 4.4.0, cidfile is removed along with the container.

Always return if container is terminated so we don't stuck in the loop
waiting for a file which has already been removed.
  • Loading branch information
kuanyili authored and mr-c committed Jan 3, 2024
1 parent 9b5a6ea commit 8ff1fd0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cwltool/job.py
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ def docker_monitor(
os.remove(cidfile)
except OSError as exc:
_logger.warning("Ignored error cleaning up %s cidfile: %s", docker_exe, exc)
return
return
try:
with open(cidfile) as cidhandle:
cid = cidhandle.readline().strip()
Expand Down

0 comments on commit 8ff1fd0

Please sign in to comment.