-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to VTK? #3
Comments
I did propose this a long time ago. If I remember correctly, for some reason they insist on having some other information (maybe "scene" information or something like that?) along with the point data when making an OBJ file, so this wasn't acceptable. Feel free to take it and propose it again if you'd like! |
I might give it a try. I recently took the time to learn how to move commits from github to their gitlab instance, so hopefully will be able to move the contents of this repo while preserving history :) Do you have an account on the Kitware gitlab? I couldn't find you there, but if not you can sign up in a few seconds using your github credentials. |
Ok I think I have an account now - let me know if you still can't find me. David |
Got it. Will try to transfer the commits sometime soon :) |
@daviddoria @waldyrious Sorry to jump in on this conversation, but I was wondering if you had made any progress on getting this merged into VTK? I was about to give it a go myself until I found your repo. It seems like it would be a really handy addition. |
I didn't have the chance to work on this. it's been on my tasks backburner since my last comment, but other stuff have been consuming my time. @DVigneault if you're comfortable with git, you could try following the steps I outlined in the link above. Let me know if you need any help. Otherwise, I will keep this on the radar to tackle as soon as I get the time. |
@waldyrious I might be mistaken, but I think the situation here is a bit different than in your linked patch, because that was a clone of the original repository, whereas this is an independent project. However, it seems to be possible to preserve authorship even with independent projects. I'm happy to give this a try, though I'm no git wizard. Maybe a more immediate issue, though: @daviddoria, I am assuming that the VTK group's qualms with this implementation haven't been resolved, as there haven't been commits since your comment? Do you have any more information about what they were requesting? No use trying to submit again if the patch hasn't changed, I guess. I tried to dig up the conversation you're referring to, but I only found this, which I don't think is the right one (I think it precedes the implementation). Whether it is added or not, thanks to you both for your work on this. |
Sorry guys, I'm way out of the loop these days, but from what I can tell No need to worry about authorship - give it a quick try but if it's too Good luck, David |
I suppose this has been discussed before, but it would be nice to have this on record here on the repo: have you considered proposing this to be added to VTK?
The text was updated successfully, but these errors were encountered: