Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Spacy 3.4.0 #22

Open
kodymoodley opened this issue Apr 21, 2023 · 8 comments · May be fixed by #26
Open

Support for Spacy 3.4.0 #22

kodymoodley opened this issue Apr 21, 2023 · 8 comments · May be fixed by #26

Comments

@kodymoodley
Copy link

Hi, I would like to use this nice package for Dutch language models that only work with Spacy 3.4.0+. How difficult would it be to support spacy 3.4.0?

@stdweird
Copy link

stdweird commented Apr 9, 2024

@davidberenstein1957 is there a reason why the pyprojct toml locks the spacy version to 3.1.X? (the readme even mentions using spacy 3.3+)

@davidberenstein1957
Copy link
Owner

Hi @stdweird @kodymoodley, I've not been too involved with maintaining this package. I will block some time to fix this coming weekend, but feel free to create a PR on top of this yourself too. I've also been wanting to fine-tune a coref model using another new package but have not gotten around to doing that as yet.

@stdweird
Copy link

stdweird commented Apr 9, 2024

@davidberenstein1957 do you suspect that we need to lock spacy (eg > 3.0, < 3.8 or simpy allow all 3.X).
and if we can run the tests, it should be enough?

@davidberenstein1957
Copy link
Owner

Yes it should be.

@matesaki
Copy link

matesaki commented Apr 16, 2024

@davidberenstein1957
Problem is with project allennlp which was ended on the version 2.10.1 with depends on spacy (>=2.1.0,<3.4)

poetry lock:
SolverProblemError
Because crosslingual-coreference depends on allennlp (==2.10.1) which depends on spacy (>=2.1.0,<3.4), spacy is required.

@matesaki matesaki linked a pull request Apr 16, 2024 that will close this issue
@davidberenstein1957
Copy link
Owner

Ahh shit. I knew that in my subconscience. I will fine-tune a new model and wrap out allennlp with fast-coref :)

@hardchor
Copy link

hardchor commented May 8, 2024

Great to hear this project is still alive! Were you able to make any progress on this?

@davidberenstein1957
Copy link
Owner

davidberenstein1957 commented May 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants