Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Allow not sending some parts of the metrics #36

Open
shanielh opened this issue Feb 25, 2016 · 2 comments
Open

Allow not sending some parts of the metrics #36

shanielh opened this issue Feb 25, 2016 · 2 comments

Comments

@shanielh
Copy link

Hi, I would like to send only some parts of the metrics.

for example, for timers I don't want to send the one_minute, five_minute and fifteen_minute mean_rate and run_count. Those values does not matter to me because I'm using HdrHistogramResetOnSnapshotReservoir (see https://bitbucket.org/marshallpierce/hdrhistogram-metrics-reservoir and http://taint.org/2014/01/16/145944a.html) which resets everything every time a snapshot is taken, So the sample size is the rate since last report.

If you'd like I can do a pull request by my own but please guide me where do you want me to make the change.

Thanks.

@davidB
Copy link
Owner

davidB commented Feb 25, 2016

PR are welcome. I have to go back into the code before to provide some
guide. I'll take a look asap.

On Thu, Feb 25, 2016 at 8:12 AM, Shani Elharrar [email protected]
wrote:

Hi, I would like to send only some parts of the metrics.

for example, for timers I don't want to send the one_minute, five_minute
and fifteen_minute mean_rate and run_count. Those values does not matter
to me because I'm using HdrHistogramResetOnSnapshotReservoir (see
https://bitbucket.org/marshallpierce/hdrhistogram-metrics-reservoir and
http://taint.org/2014/01/16/145944a.html) which resets everything every
time a snapshot is taken, So the sample size is the rate since last report.

If you'd like I can do a pull request by my own but please guide me where
do you want me to make the change.

Thanks.


Reply to this email directly or view it on GitHub
#36.

@shanielh
Copy link
Author

shanielh commented Mar 4, 2016

@davidB Looking forward for your reply 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants