From fd508aaf2c69ffbb84a70cc4aeb4c53658d07657 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 9 Jul 2024 15:17:24 +0200 Subject: [PATCH] ci: run more checks in private repositories Though devtools/checkpatches.sh is run as part of our CI, some other (not well known) checks could help when run in private repositories before submitting to the mailing list and even when run from the ovsrobot. Most of them require a git history or checked sources to run. And I can't guarantee there won't be false positives. Add a new job just for those checks so that it won't block compilation tests in other jobs. Signed-off-by: David Marchand Signed-off-by: Robin Jarry Acked-by: Aaron Conole --- .ci/linux-build.sh | 2 -- .github/workflows/build.yml | 24 +++++++++++++++++++++++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 15ed51e4c18..fdb57876211 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -148,8 +148,6 @@ if [ "$ABI_CHECKS" = "true" ]; then export PATH=$(pwd)/libabigail/bin:$PATH - REF_GIT_REPO=${REF_GIT_REPO:-https://dpdk.org/git/dpdk} - if [ "$(cat reference/VERSION 2>/dev/null)" != "$REF_GIT_TAG" ]; then rm -rf reference fi diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a6436c2c461..f271defe03e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,30 @@ defaults: run: shell: bash --noprofile --norc -exo pipefail {0} +env: + REF_GIT_BRANCH: main + REF_GIT_REPO: https://github.com/DPDK/dpdk + REF_GIT_TAG: none + jobs: + checkpatch: + if: github.repository != 'DPDK/dpdk' + name: Check patches + runs-on: ubuntu-24.04 + steps: + - name: Checkout sources + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Check patches + run: | + git remote add upstream ${{ env.REF_GIT_REPO }} + git fetch upstream ${{ env.REF_GIT_BRANCH }} + failed= + devtools/check-doc-vs-code.sh upstream/${{ env.REF_GIT_BRANCH }} || failed=true + devtools/check-meson.py || failed=true + devtools/check-symbol-maps.sh || failed=true + [ -z "$failed" ] ubuntu-vm-builds: name: ${{ join(matrix.config.*, '-') }} runs-on: ${{ matrix.config.os }} @@ -27,7 +50,6 @@ jobs: MINGW: ${{ matrix.config.cross == 'mingw' }} MINI: ${{ matrix.config.mini != '' }} PPC64LE: ${{ matrix.config.cross == 'ppc64le' }} - REF_GIT_TAG: none RISCV64: ${{ matrix.config.cross == 'riscv64' }} RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }} STDATOMIC: ${{ contains(matrix.config.checks, 'stdatomic') }}