Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF rendering #47

Open
EvgeniiaVak opened this issue Jul 30, 2020 · 3 comments
Open

PDF rendering #47

EvgeniiaVak opened this issue Jul 30, 2020 · 3 comments
Labels
question Further information is requested

Comments

@EvgeniiaVak
Copy link
Contributor

PDF rendering can be done by browser - we would just need to embed the object tag with pdf.
e.g. with an oddk file:

<object data="https://cc-p-minio.ckan.io/ckan/opendatadenmark-prod/resources/3f2d5f2b-8659-4995-926a-8fe77798daff/bilag-1-trafiktaellinger-kobenhavnskommune.pdf?AWSAccessKeyId=2effdd1004072cb9&Expires=1596084974&Signature=2Q95679q22UfImIKDbiGEU63Enw%3D" width="400" height="500"></object>

Why are we doing PDF rendering in datapackage-views-js?

One hypothesis is to support pagination.
@EvgeniiaVak EvgeniiaVak added the question Further information is requested label Jul 30, 2020
@EvgeniiaVak
Copy link
Contributor Author

refs #46

@EvgeniiaVak
Copy link
Contributor Author

cc @anuveyatsu

@anuveyatsu
Copy link
Member

@EvgeniiaVak I agree that we can/should simplify PDF rendering logic. Having pagination might be important feature for some users. I personally would just have a link to a PDF file and I could preview it using my own tool.

Note datapackage-views-js running in browser as it's a React app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anuveyatsu @EvgeniiaVak