Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define proptypes #22

Open
4 tasks
starsinmypockets opened this issue Aug 27, 2019 · 1 comment
Open
4 tasks

Define proptypes #22

starsinmypockets opened this issue Aug 27, 2019 · 1 comment

Comments

@starsinmypockets
Copy link
Contributor

As a developer I want the proptypes declaration to guide my use of the component so I know what to pass to the component

Tasks

  • read up on proptypes
  • enable proptypes lib
  • define proptypes

Acceptance

  • exported component has proptypes declaration
@starsinmypockets
Copy link
Contributor Author

For instance, instantiating as follows:

<DataView key={i} name="Foo" datapackage={displayItem}  />

Throws

DataView(...): Nothing was returned from render. This usually means a return statement is missing. Or, to render nothing, return null.

Which is difficult to debug. Proptypes would clarify the reason for the failure to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant