-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingressClassName
and segregate generated Ingress
resources
#24
Comments
Thanks for the suggestions @pinkfloydx33 👍 So we should be replacing the If you (or anybody else) would like to take a stab at this PRs are most welcome, otherwise we'll take a look next time we do a round of work on the chart. |
Hi, I created a PR with this feature (#25), coudl your analyze/aprove please? Regards |
Ah, sorry @caiohasouza I missed the branch name in #25, we should have targeted |
Hi @KodrAus Cool, do you have some estimate time to release new version? Sorry but i have a necessity to add the ingressClassName to be possible proceed with Kubernetes 1.22 upgrade. Regards |
Ah no problems, I'll get a release of the Helm chart together for you now. |
Hi @KodrAus Perfect, thank you so much, i'm waiting. Regards |
Thanks for your patience on this one @caiohasouza. We had some trouble getting a build through on Friday we could release, but have one ready to go now. I'll drop another update here once it's all published. |
Alrighty, we've just published |
Hi @KodrAus Perfect, thank you so much! Regards |
Please consider adding support for
spec.ingressClassName
when creatingIngress
resources. This field has replaced the deprecated ingress class annotations. There is currently no way to specify this on the generated resources and so must be managed manually. Please add first-class support for this feature.Additionally, I'd ask that you consider splitting the UI/Ingestion ingresses into separate
Ingress
resources so that a different value foringressClassName
may be specified for each of them.Why I need the latter: we run two different ingress controllers in our environment; one is for public traffic and the other is for internal/private network traffic. We expose the Seq UI publicly via the first controller (mainly to support AzureAD) and run the auxiliary ingestion endpoint over the private network only.
I must currently manage the Seq ingresses since I both need the
ingressClassName
feature and for it to differ between the two ingressesThe text was updated successfully, but these errors were encountered: