-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of monitoring output execution together with execution phase #312
Rework of monitoring output execution together with execution phase #312
Conversation
I checked few other examples linked with code execution (for example KernelExecution) - looks like they all work as before |
Hey @echarles Do you have time today to check this? I hope it's final (in short term) improvement that I need for my project to go further... |
I am working atm on a branch with quite some changes. I will review and comment by tomrrow your changes, hopefully there will be no merge conflict, not sure. |
738334b
to
b8a95bd
Compare
…/github.com/sok82/jupyter-ui into feat-290-fix-for-monitoring-execution-phase
@echarles I fixed conflicts, it seems like ok now. Can you squash all commits before merging them into main after checking PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT Thx @sok82
Just released 0.18.8. Thx @sok82 |
After hours of struggling with monitoring of output execution using
OutputAreaModel
changes I reworked previous functionality connected with monitoring to simple and convenient form of attaching one simple listener to output enabling user to monitor output changes.Changes addressing rework of #290.
Result is demonstrated in new example called
OutputWithMonitoring
It works like this - attaching simple listener which gets new output area model and execution phase in one object
Below you can find sceenshot with visual representation of monitored events - it works both when we have new output or when executor generates no output at all, or when execution completes with error