Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control when a Cell is executing #279

Closed
MarcosVn opened this issue Jul 29, 2024 · 2 comments
Closed

Control when a Cell is executing #279

MarcosVn opened this issue Jul 29, 2024 · 2 comments

Comments

@MarcosVn
Copy link
Contributor

Problem

  • I have an action in my web application to execute a group of <Cell>;

    • image
  • If the user performs this action before the code from a previous execution has finished, we get the following error:

    • image

Proposed Solution

  • My proposed solution (similar to what we already have for sessions during initialization, for example) would be to have an isExecuting attribute in the CellState for each cell and an isAnyCellExecuting to indicate if there is at least one cell executing.
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Jul 29, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Jul 29, 2024
@MarcosVn
Copy link
Contributor Author

MarcosVn commented Jul 30, 2024

Hey, @echarles!
I submitted this PR with the proposed solution. I included comments, evidence, and more information there. Thank you!

MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Jul 31, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Jul 31, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Jul 31, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Aug 1, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Aug 1, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Aug 2, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Aug 2, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Aug 2, 2024
MarcosVn pushed a commit to MarcosVn/jupyter-ui that referenced this issue Aug 2, 2024
echarles pushed a commit that referenced this issue Aug 2, 2024
* feat: add state control for cell execution (#279)

* feat: add example for cell execution control (#279)

* fix: reject promise error cases in onReply (#279)

* feat: improve kernelexecutor error reject (#279)

---------

Co-authored-by: Marcos Alves <[email protected]>
@MarcosVn
Copy link
Contributor Author

MarcosVn commented Aug 2, 2024

@echarles, as far as I'm concerned, the issue can be closed once the version with the update is published.

Thank you!

@echarles echarles closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants