-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency of interpolate function on resampling #222
Comments
I think you make a good point @smvazirizade, we should probably have a cleaner separation of interpolation for filling in missing values from interpolation for the purposes of upsampling. @guanjieshen - thoughts? |
Thanks for bring this up @smvazirizade. In your example, would you expect the If it's the later df = input_tsdf.interpolate(
partition_cols=["signal"],
ts_col="timestamp"
freq="1 minute",
func="mean",
method="linear",
target_cols= ["value"],
show_interpolated=True,
).df.filter(df.is_ts_interpolated == True) This uses the supplemental boolean columns to exclude any new timestamps that were generated by the interpolation. If the intention is for it to be @tnixon Good call out on the distinction between upsampling vs filling in missing values use cases. I think is something we can incorporate into the API for an upcoming release. The ability to perform ffill or bfill on STRING columns is something we can also add support for fairly easily. |
Thank you for the response and attention to this issue. |
Hi @tnixon and @guanjieshen , |
This issue is regarding interpolate function. It seems the arguments freq and func should always be provided, either as an argument in interpolate function or through resampling function.
Assume, I have a timeseries data with unequal timesteps. For some reason, some of the samples are None values and I want to replace them with linear interpolation without adding or removing any rows (please see the figure below). However, the dependency of interpolate function on resampling makes this process virtually impossible.
Please let me know if there is any solution for that or that would be great if this feature can be implemented.
Also, it causes other problems too. Assume there is a string column that is not used for either partitioning or interpolation. The interpolation function dumps those columns, and by enforcing resampling, I have no chance to merge them to bring them back.
PS: I believe string columns should be allowed with ffill and bfill.
The text was updated successfully, but these errors were encountered: