Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

best_params_ not supported by RandomizedSearchCV() #105

Open
shaunswanson opened this issue Feb 5, 2019 · 1 comment
Open

best_params_ not supported by RandomizedSearchCV() #105

shaunswanson opened this issue Feb 5, 2019 · 1 comment

Comments

@shaunswanson
Copy link
Contributor

The documentation for RandomizedSearchCV implies that a best_params_ property is available after .fit() is called. This does not appear to be the case.

Here is the documentation in question:

https://github.com/databricks/spark-sklearn/blob/master/python/spark_sklearn/random_search.py#L162

Should I attempt to implement a best_params_ property or indicate in the documentation that best_params_ is not supported (as it is a common API in sklearn-related libraries) in a PR?

@srowen
Copy link
Collaborator

srowen commented Feb 5, 2019

Yes I think this is basically #73 which I don't know how to resolve. It's not clear we can set this field. Yeah the docs should be fixed if not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants