Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotMIRAProfiles refers to sampleName from out of scope #27

Open
nsheff opened this issue Jul 14, 2020 · 2 comments
Open

plotMIRAProfiles refers to sampleName from out of scope #27

nsheff opened this issue Jul 14, 2020 · 2 comments
Labels
bug

Comments

@nsheff
Copy link
Member

nsheff commented Jul 14, 2020

MIRA/R/plotting.R

Line 67 in 930be3b

geom_line(aes(group = sampleName)) +

similar issue raised in #14
@nsheff nsheff added the bug label Jul 14, 2020
@j-lawson
Copy link
Contributor

Hi Nathan,

The function documentation indicates that "sampleName" is a required column. When sampleName is a column in the input data.frame, it can be referred to without quotes in ggplot.

@nsheff
Copy link
Member Author

nsheff commented Jul 15, 2020

I see. probably not the best way to do things, though. something should check and catch that, then.

I am trying to use mira and struggling with some of the UI, so I might take a shot at revamping a few things if I can get to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsheff @j-lawson