Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the user expected to add a window around her peaks? #98

Open
holgerbrandl opened this issue Oct 2, 2018 · 4 comments
Open

Is the user expected to add a window around her peaks? #98

holgerbrandl opened this issue Oct 2, 2018 · 4 comments

Comments

@holgerbrandl
Copy link

Co-localization/enrichment relies on some defined proximity window. But since the UI does not expose any such window-size, I'm wondering if we have to expand the query sets (e.g. macs2 peaks in my case) using bedtools slop (or similar)?
Or is the user supposed to upload peaks as they come from the caller, and LOLA deals with some definition of proximity internally?

@nsheff
Copy link
Member

nsheff commented Oct 2, 2018

LOLA is going to just treat your regions exactly as you provide them. So, it assumes you've pre-processed them to be the exact size you want them to be.

It would be possible for us to make some simple resizing options. Maybe we should do that... the problem is just that it's so biology-specific, that it would be really hard to please everyone, you know?

@holgerbrandl
Copy link
Author

Indeed it's really hard to define what vicinity really means. But pointing out the necessity of doing so before/when using LOLA would be helpful imho.

@nsheff
Copy link
Member

nsheff commented Mar 12, 2019

@vpnagraj it actually wouldn't be too hard to add another field in the shiny app called 'padding', which could be useful. What do you think?

we would just then use this 'padding 'parameter to run a GenomicRanges::resize() call on the uploaded regions.

@vpnagraj
Copy link
Collaborator

@nsheff sure thing

but i'm not familiar with GenomicRanges::resize() so can you give you me a better idea of where to make that call? after reading each .bed?

and given that a user might upload multiple region sets, would the padding be the same on all files?

it would also help to know what the range of possible values (and a sensible default) for that padding value would be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants