Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify register order #2740

Merged
merged 1 commit into from
Dec 18, 2024
Merged

modify register order #2740

merged 1 commit into from
Dec 18, 2024

Conversation

atalyaalon
Copy link
Collaborator

No description provided.

@atalyaalon atalyaalon linked an issue Dec 18, 2024 that may be closed by this pull request
Modify Widgets order #2739
Closed
@atalyaalon atalyaalon requested a review from ziv17 December 18, 2024 15:12
@atalyaalon atalyaalon merged commit 12accf8 into dev Dec 18, 2024
3 checks passed
@atalyaalon atalyaalon deleted the 2739-modify-widgets-order branch December 18, 2024 18:58
@ziv17
Copy link
Collaborator

ziv17 commented Dec 20, 2024

Hi @atalyaalon ,
Why was it needed?

@atalyaalon
Copy link
Collaborator Author

@ziv17
Apparently the import order changes the order of the widgets in our API and hence the order of their appearance in the UI.
I preferred having all_locations_widgets first, and no_location_widgets last.

@ziv17
Copy link
Collaborator

ziv17 commented Dec 26, 2024

@atalyaalon
We can have specific order. What is the priority of this?

@atalyaalon
Copy link
Collaborator Author

@ziv17 not a priority for now. We'll keep current order with the small modification I made in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziv17 ziv17 Awaiting requested review from ziv17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify Widgets order
2 participants
@atalyaalon @ziv17